Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: body used already error fix #340 #346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: body used already error fix #340 #346

wants to merge 1 commit into from

Conversation

Ephigenia
Copy link
Contributor

Fix "body used already for" error message as json and text is called. Should fix #340

@Ephigenia Ephigenia mentioned this pull request May 22, 2023
Open
nchaulet
nchaulet reviewed Oct 29, 2023
View reviewed changes
lib/httpadapter/fetchadapter.js
@@ -42,10 +42,11 @@ class FetchAdapter {
if (fullResponse) {
return res;
}
const rawResponseBody = res.text();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need an await here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch adapter should not call body.text() if body.json() throws an error
2 participants
@Ephigenia @nchaulet