Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an additional here geocoder which provides suggestions to given… #210

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ccaliskan
Copy link

Here geocoder gave very unsatisfying suggestions to my address searches. So i added an intermediate step, that calls the suggestions API of Here. The given suggestions are then being geocoded by their location ids.

@nchaulet
Copy link
Owner

nchaulet commented Mar 6, 2017

I am not sure that is the best way to do it maybe we can extends the existing Here geocoder to do that and not create a new one.

Do you know if suggestion is something that other geocoding API provide ? google ? ...

Thanks and I will be happy to help you with this problem.

@ccaliskan
Copy link
Author

Thanks for your reply.

The reason for a new geocoder was to touch as little existing code as possible.
But if you think it is better to extend the existing one, i'm perfectly ok with it. How would you do it? With a flag (suggestions on/off) or with a new function?

I had a look at Google, they provide suggestions via their Places API (autocomplete, they call it).
TomTom has a fuzzy search with a typeahead query parameter, which seems to do the same job.
OSM does not provide suggestions.
Unfortunately i have no other experience with geocoding other than Here maps.

@nchaulet
Copy link
Owner

nchaulet commented Feb 6, 2022

run integrations test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants