Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped autochrome_junk_drawer to manifest v3 #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bumped autochrome_junk_drawer to manifest v3 #33

wants to merge 3 commits into from

Conversation

mephesto1337
Copy link

It now uses declarativeNetRequestWithHostAccess which 'statically'
modifies requests with rules (useragent_tag_$COLOR.json) depending on
the theme currently loaded.
It also needs the management permission in order to determine which
profile/theme is currently being used.

As manifest v2 will stop working during 2023, it seems to me as a good time to upgrade.

@mephesto1337
Bumped autochrome_junk_drawer to manifest v3
4f6e12d 
It now uses `declarativeNetRequestWithHostAccess` which 'statically'
modifies requests with rules (useragent_tag_$COLOR.json) depending on
the theme currently loaded.
It also needs the `management` permission in order to determine which
profile/theme is currently being used.
As manifest v2 will not work during 2023, it seems to me as a good time
to upgrade.
@mephesto1337
Includes all resourceTypes
48c2204 
If no `resourceTypes` is specified, then not all requests are matched.
@peter-h-ncc
Copy link
Collaborator

Can you provide a link to details of manifest v2 being deprecated for documentation purposes? This looks like a change that I should merge sooner rather than later, any documentation is appreciated.

@mephesto1337
Copy link
Author

Hello, here is the link : https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/.
Its deprecation has been a bit postponed. It seems than in early 2024 (the date is still under review), extensions using the v2 manifest will stop working.

@mephesto1337 mephesto1337 reopened this Feb 27, 2023
@mephesto1337
Copy link
Author

I should also note that I had to had a new custom header x-autochrome-tag. The new API does not allow modifying headers (only, add, delete and set). So I "set" the User-Agent with a fixed version of chrome and added the new header.
If a breaking change has to happened, both headers should be present for some time I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting_response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mephesto1337 @peter-h-ncc