Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onnxruntime v1.8.1 with GPU/CUDA 11 support #87

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

haixuanTao
Copy link

@haixuanTao haixuanTao commented Jul 23, 2021

Merging two branches together to enables CUDA 11 Support on ONNX 1.7

The first one is: #78
The second one is: https://github.com/radu-matei/onnxruntime-rs/tree/cuda

This solution may not be perfect but wanted to share it with others. I am available to add or maintain this branch if you have any recommendations to make it better :)

Thanks for the work of @radu-matei, @dkim, @dllu, which is the base for this PR 🥇

@haixuanTao haixuanTao changed the title Onnxruntime v1.7.0 with CUDA 11 support Onnxruntime v1.7.0 with GPU/CUDA 11 support Jul 23, 2021
@nbigaouette
Copy link
Owner

Thanks for the contribution!

Sorry for my late replay, I don't have much time to put on that project...

I updated the bindings yesterday to 1.8.1. Would you mind pushing commits just for the CUDA stuff? Or I can cherry-pick the two if you prefer.

@haixuanTao haixuanTao force-pushed the onnxruntime-v1.7.0 branch 2 times, most recently from a4a688d to be04fbe Compare August 5, 2021 20:41
@haixuanTao haixuanTao changed the title Onnxruntime v1.7.0 with GPU/CUDA 11 support Onnxruntime v1.8.1 with GPU/CUDA 11 support Aug 5, 2021
@haixuanTao
Copy link
Author

All set!

I have rebase from master !

I did not push the bindings for Windows as I have no machine to test it on.

Feel free to leave comment on necessary modification :)

@codecov-commenter
Copy link

Codecov Report

Merging #87 (7578dc0) into master (312952b) will decrease coverage by 1.70%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   16.11%   14.40%   -1.71%     
==========================================
  Files          19       20       +1     
  Lines        1117     1277     +160     
==========================================
+ Hits          180      184       +4     
- Misses        937     1093     +156     
Impacted Files Coverage Δ
onnxruntime-sys/build.rs 0.00% <0.00%> (ø)
...untime-sys/src/generated/macos/aarch64/bindings.rs 0.00% <0.00%> (ø)
...runtime-sys/src/generated/macos/x86_64/bindings.rs 0.00% <ø> (ø)
onnxruntime/src/download.rs 0.00% <0.00%> (ø)
onnxruntime/src/lib.rs 41.48% <0.00%> (-1.07%) ⬇️
onnxruntime/src/session.rs 0.00% <0.00%> (ø)
onnxruntime/src/tensor/ort_owned_tensor.rs 0.00% <0.00%> (ø)
onnxruntime/src/error.rs 58.33% <50.00%> (-4.17%) ⬇️
onnxruntime/src/environment.rs 88.52% <66.66%> (-1.31%) ⬇️
onnxruntime/src/memory.rs 87.50% <80.00%> (-5.84%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c6bab...7578dc0. Read the comment docs.

fix apple gpu download bug

adding windows bindings

fixing apple no gpu problem

fixing workflow mistake
@haixuanTao
Copy link
Author

This branch should pass test now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants