Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form submit refactors for Site Warning & Share notebooks #851

Merged
merged 8 commits into from
Jul 7, 2023

Conversation

manfromjupyter
Copy link
Contributor

@manfromjupyter manfromjupyter commented May 16, 2023

Separating this to keep the PR small. Aims to work closer towards closing #639 and #848

DONE

  1. Made site warning type/level buttons into an actual radio button instead of buttons people forget to click
  2. Added support to clear of the field and for the submit button to be disabled when clearing data.
  3. Got disable submit form working for Site Warnings, Share Notebook with users, and ....

Status since #848

Form Summary Disable/Enable support status
Admin - Site Warning#Create Good (now) Design only (but now disabled by default with this PR)
Admin - Site Warning#Edit Good (now) N/A - will be all filled out already by default, just is disabled upon removing fields by Design only.
Admin - Site Warning#Delete Perfect (now) DONE - always able to be clicked after site warning has been created. Hidden on new site warnings (now)
Admin - Site Warning#Clear (NEW) Perfect (new) DONE - always able to be clicked on new site warning.
Share Notebook with Users Perfect (now) DONE (with this PR)

@manfromjupyter manfromjupyter marked this pull request as draft May 16, 2023 17:42
…le forget to click then made it support clearing of the field and for the submit button to be disabled when clearing data
@manfromjupyter manfromjupyter changed the title Submit Buttons Properly Disable/Enable Form submit refactors for Site Warning & Share notebooks Jun 21, 2023
@manfromjupyter manfromjupyter marked this pull request as ready for review June 21, 2023 16:47
Copy link
Contributor

@mcrutch mcrutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info/error radio buttons styles are broken
image

@manfromjupyter
Copy link
Contributor Author

manfromjupyter commented Jun 29, 2023

@mcrutch Dark theme issue has been fixed

@mcrutch
Copy link
Contributor

mcrutch commented Jul 5, 2023

Is it intended to look this much worse? (Not just Dark theme)

Main
image

enforce-form-requirements
image

@manfromjupyter
Copy link
Contributor Author

@mcrutch I think this is ready now. Consistently formatted checkboxes and radio button fields in inlined forms and modal forms. Affects Propose Review, Feedback form, and Site Warning forms

@mcrutch mcrutch merged commit b9ead6f into main Jul 7, 2023
4 checks passed
@mcrutch mcrutch deleted the enforce-form-requirements branch July 7, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants