Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Refactor #849

Merged
merged 5 commits into from
May 16, 2023
Merged

Label Refactor #849

merged 5 commits into from
May 16, 2023

Conversation

manfromjupyter
Copy link
Contributor

@manfromjupyter manfromjupyter commented May 15, 2023

Closes #771 and partially #639

Will address #850 after this.

DONE

  1. All labels appropriately written using semantic <label>
  2. New labels added to many fields and all now are supporting blind users using screen readers more appropriately.
  3. ID's moved to front of attributes for easier readability.
  4. All required attributes written as requires="required"
  5. Fixed numerous places where classnames were not written in SLIM HTML format ex. div.classname1.classname2
  6. Fixed misalignment of search help tooltip on non-home page search bars.
  7. Changed "User name" on User Edit form to "Username" to match the rest of our front end.

@manfromjupyter manfromjupyter marked this pull request as draft May 15, 2023 20:07
@manfromjupyter manfromjupyter marked this pull request as ready for review May 16, 2023 15:14
@mcrutch mcrutch merged commit d156404 into main May 16, 2023
4 checks passed
@mcrutch mcrutch deleted the label-refactor branch May 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using input labels incorrectly
2 participants