Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No make install (cpp version) #61

Open
baerbock opened this issue Jul 3, 2019 · 8 comments · May be fixed by #140
Open

No make install (cpp version) #61

baerbock opened this issue Jul 3, 2019 · 8 comments · May be fixed by #140

Comments

@baerbock
Copy link

baerbock commented Jul 3, 2019

Dear nayuki,

why have you not included an "install" option for the Makefile https://github.com/nayuki/QR-Code-generator/blob/master/cpp/Makefile ?

@nayuki
Copy link
Owner

nayuki commented Jul 6, 2019

Because I haven't learned how make install works, and because this library is not stable enough to be considered a system library.

@baerbock
Copy link
Author

baerbock commented Jul 6, 2019

@nayuki Isn't your library getting included into LibreOffice with hundreds of millions of users? I don't have a better proof, but what else is this?

@reneengelhard
Copy link

reneengelhard commented Jul 28, 2019

@baerbock

yes, LibreOffice includes this.

But see the discussion in https://gerrit.libreoffice.org/#/c/73302/
@nayuki is right, this package is not very stable IMHO, let alone because it all is called libqrcodegen.so.1 (which makes them all non-coinstallable and thus Debian seems to have to do https://sources.debian.org/src/qr-code-generator/1.4.0-1/debian/patches/cpp-lib.patch/?hl=25#L25 to have it be able to install parallel.

That it has a check to build against a system library is a given, I am not going to build with a internal library if a system library was readily available. If it wasn't available in Debian I would have probably packaged it myself which then would have been resulted in either a similar patch as above or a bug here ;-)
(This libqrcodegencpp is also what LibreOffice checks against right now.)

@reneengelhard
Copy link

if there will be a make install; it should be for libqrcodegencpp (see my previous comment)

@nayuki
Copy link
Owner

nayuki commented Jul 28, 2019

This is all way over my head, but thanks for the commentary!

@reneengelhard
Copy link

In a nutshell: see #63

@reneengelhard
Copy link

reneengelhard commented Jul 28, 2019

and note the referenced patch (amongst other things) implements make install :-)

@rahiel
Copy link

rahiel commented Jan 3, 2023

For future reference:

This library was included in libreoffice in 2019: LibreOffice/core@b4141ca
And it was removed (replaced) in 2021: LibreOffice/core@66e88f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@nayuki @rahiel @reneengelhard @baerbock and others