Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not open pull requests. I will reject them. #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nayuki
Copy link
Owner

@nayuki nayuki commented May 27, 2020

If you are a beginner programmer, do not open a pull request to contribute your code to my Project Euler solutions. I will almost certainly reject your PR and form a negative opinion of you.

I expect quality work, and most will not meet high standards.
Keep your work in your own repository and do not contact me.

Here is a history of rejected changes. Some have detailed explanations of why they are unsuitable. https://github.com/nayuki/Project-Euler-solutions/pulls?q=is%3Apr+is%3Aclosed

Also, do not contribute new programming languages to my collection of solutions. I am not willing to spend the effort to bring those pieces of code up to my current quality standards and to continually keep them in sync with the other languages as new changes are made.

@nayuki
Copy link
Owner Author

nayuki commented May 27, 2020

If you are competently skilled in both math and programming, and you have a new idea/algorithm/implementation to offer, please proofread and edit your work very carefully before opening a pull request.

At the very minimum, your work needs to meet these criteria (which does not guarantee acceptance):

  • Your logic must be mathematically correct - calculating the right answer, following the rules, and not omitting tricky cases.
  • Your code must respect my indentation, spacing, and naming style. Look at my existing body of work for examples to imitate. A much longer reference document is at https://www.nayuki.io/page/my-code-style .
  • You must not needlessly add/modify/delete unrelated files or lines of code, as this is noise and pollution. For example, do not reformat my existing whitespace, and do not add IDE-specific files.
  • You must not break any existing functionality that I currently support, such as automated unit testing.

@nayuki nayuki mentioned this pull request May 27, 2020
Repository owner locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant