Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple linux build script #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

simple linux build script #39

wants to merge 1 commit into from

Conversation

apelly
Copy link

@apelly apelly commented Mar 4, 2020

roughly translate the existing batch file to bash for ease of building
under ubuntu

...may be of use to someone other than me

@navossoc
Copy link
Owner

navossoc commented Mar 4, 2020

Do you mind if I ask why you compile yourself the plugin?

@apelly
Copy link
Author

apelly commented Mar 4, 2020

Do you mind if I ask why you compile yourself the plugin?

Not at all... I've had issues with keepass plugins in the past. By translating your build script I get to:

  • automate the installation
  • document what's going on
  • clone your repo locally so I can find it in the future
  • easily update my local repo
  • cherry pick whatever patches you haven't created a release for yet
  • hack on the source should I wish
  • review individual commits
  • other weak reasons that I forget 😀

@tgr
Copy link

tgr commented Mar 27, 2020

Also including opaque binaries from untrusted sources defeats the point of a secure password manager somewhat.

tgr
tgr reviewed Mar 27, 2020
View reviewed changes
ubuntu-plgx-build.sh Outdated

# Deploy PLGX file
echo Deploying...
sudo cp ${NAME}.plgx ${PLGX_LOX}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be _LOC.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. It's almost like I didn't test it at all.

@apelly
simple linux build script
3dbb664 
roughly translate the existing batch file to bash for ease of building
under ubuntu
@koppor koppor mentioned this pull request Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgr tgr tgr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apelly @navossoc @tgr