-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flavio/issue 12 #20
Draft
f-hafner
wants to merge
13
commits into
master
Choose a base branch
from
flavio/issue-12
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Flavio/issue 12 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-hafner
commented
Jan 8, 2024
@@ -417,23 +417,34 @@ def make_html(self, text, nouns, subjs, custom, custom_dict, selected_prominence | |||
selected_tags.append(self.pos_tags["custom"]) | |||
|
|||
selected_tags = [tag for taglist in selected_tags for tag in taglist] | |||
|
|||
|
|||
metric = prominence_map[selected_prominence_metric] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and the following lines use the vectorization in pandas and avoid the repeated subsetting of the dataframe during the for loop that was done before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #12
Description of changes
Main change: In the actor tagger, the method
postag_text
is split into two: (1)make_html
that generates the html for the GUI, and (2)postag_text_to_table
that runs the NLP model does that POS tagging.Details of the change:
postag_text_to_table
creates two dataframes that are indexed by the sentence identifier:self.sentence_df
with the sentence text;self.entities_df
with the start&end index of the POS tagged entities and the two prominence score metricsmake_html
queries the two dataframes created above, filters on selected prominence score and threshold, and creates the html for display.This is an imperfect solution:
__update_postagging_metrics
. -> do we need to rerun this somewhere?Smaller changes:
OWSNActorAnalysis
for compatibility with python>3.9Open tasks
TODO (PR)
orTODO NOW
Includes