Separate albums by MusicBrainz Album ID #2538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use mbzAlbumID to generate albumID
add sort by mbz_album_id
MbzAlbumID
add mbzAlbumID to DiscID type
split albums by mbzAlbumID
mbzAlbumID support
mbzAlbumID support
add sort by mbzAlbumID
|
Download the artifacts for this pull request: |
fix conflict
remove time package
cleaner s.albumID() function
temporary fix to make merge possible
AlbumID can only be generated after MbzAlbumID is read
certuna
added a commit
to certuna/navidrome
that referenced
this pull request
Nov 5, 2023
revert some stuff that's already covered in navidrome#2538
tab screws up lint
certuna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #489
Separates album releases by MbzAlbumID, in the same way it splits by Release Date. The MbzAlbumID tag was already read/stored by Navidrome, so no changes to the DB or API.
Follows the same config option
Scanner.GroupAlbumReleases=true/falseas introduced in #2162 that shows different releases either as separate album entities or as different "discs" within one album, so no changes required from the user end.