Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: added rpm spec file #513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sergey-safarov
Copy link

@sergey-safarov sergey-safarov commented Jan 29, 2022

PR related to #483 discussion

%define debug_package %{nil}

Name: libnats
Version: 3.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently at version 3.2.0. Also, would be nice if that could be updated when generating version, otherwise it will need to be manually updated before I do a new release..

%files devel
%dir %{_includedir}/nats
%dir %{_includedir}/nats/adapters
%{_includedir}/nats.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't install nats.h in the root of include directory, instead it is installed under nats directory inside the include directory. We used to put it in top-level include directory, but we no longer do.
To be precise, we put under the include directory the file deprnats.h that is renamed nats.h, to indicate that users should use nats/nats.h instead.
So maybe we should not add it here? (unless I completely misunderstand what this is doing).

%{_prefix}/lib/cmake/cnats/*.cmake

%changelog
* Sat Nov 06 2021 Sergey Safarov <s.safarov@gmail.com> 3.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe refresh the date here and change the version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants