[FIXED] Fix to properly deal with block scopes in lexer. #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug that was reported that was not handling a block scope where the terminating '}' was on a new line. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
wallyqs
reviewed
May 10, 2024
Add new else based on PR feedback. Co-authored-by: Waldemar Quevedo <wally@synadia.com>
neilalexander
pushed a commit
that referenced
this pull request
May 16, 2024
We had a bug that was reported that was not handling a block scope where the terminating '}' was on a new line. Resolves: #5396 Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io> Co-authored-by: Waldemar Quevedo <wally@synadia.com>
wallyqs
added a commit
that referenced
this pull request
May 16, 2024
We had a bug that was reported that was not handling a block scope where the terminating '}' was on a new line. Resolves: #5396 Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io> Co-authored-by: Waldemar Quevedo <wally@synadia.com>
neilalexander
added a commit
that referenced
this pull request
May 16, 2024
neilalexander
added a commit
that referenced
this pull request
May 16, 2024
…)" This reverts commit d44808e.
wallyqs
added a commit
that referenced
this pull request
May 16, 2024
We had a bug that was reported that was not handling a block scope where the terminating '}' was on a new line. Resolves: #5396 Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io> Co-authored-by: Waldemar Quevedo <wally@synadia.com>
bruth
pushed a commit
that referenced
this pull request
May 16, 2024
wallyqs
added a commit
that referenced
this pull request
May 16, 2024
…)" This reverts commit 687879d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug that was reported that was not handling a block scope where the terminating '}' was on a new line.
Resolves: #5396
Signed-off-by: Derek Collison derek@nats.io