[ADDED] Allowed connection type "in process" #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the JWT library update, there is now a `jwt.ConnectionTypeInProcess` connection type that can be added to the list of allowed connection types when defining an user. If the list is not empty and does not have this type, an "in process" connection will not be allowed. Conversely, it is now possible to limit a user to be used only for in process connections (or several types based on the content of the list). Possible solution for #5387 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison This would be a possible solution to issue #5387. If you think this is reasonable, I will make the JWT PR, have it merged, and then update this PR with the new JWT lib dep and open this for formal review. |
|
Will take a look. |
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison I have updated the PR with the go.mod change to point to newly released JWT library that adds the "in process" connection type and updated the test to cover JWT test. It is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the JWT library update, there is now a
jwt.ConnectionTypeInProcessconnection type that can be added to the list of allowed connection types when defining an user. If the list is not empty and does not have this type, an "in process" connection will not be allowed.Conversely, it is now possible to limit a user to be used only for in process connections (or several types based on the content of the list).
Possible solution for #5387
Signed-off-by: Ivan Kozlovic ivan@synadia.com