Retry for stale reads in KV CAS chaos test #4769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprimi
force-pushed
the
marco/chaos_test_kv_direct_get
branch
from
6ad58b4
to
a743862
Compare
mprimi
changed the title
|
@derekcollison updated to leave (2 commits for easier review, squashable on merge) |
derekcollison
requested changes
Nov 9, 2023
mprimi
force-pushed
the
marco/chaos_test_kv_direct_get
branch
from
a743862
to
564661c
Compare
|
Updated indentation in 2nd commit |
mprimi
force-pushed
the
marco/chaos_test_kv_direct_get
branch
from
564661c
to
88a10b1
Compare
|
Just rebased, the Jenkins error comes from Run non JetStream/MQTT tests from the server package:: |
mprimi
force-pushed
the
marco/chaos_test_kv_direct_get
branch
from
88a10b1
to
136687e
Compare
|
Can we check the failures, seems all tests fails so probably failed staticcheck or something. Also, @mprimi is this the test that shows reset you wanted us to look at? |
|
@derekcollison this got stale, I'll rebase. The failing RAFT i mentioned is a different (draft) PR: #4626 |
Signed-off-by: Marco Primi marco@synadia.com
When detecting a stale value, retry rather than fail immediately. Signed-off-by: Marco Primi marco@synadia.com
Signed-off-by: Marco Primi marco@synadia.com
mprimi
force-pushed
the
marco/chaos_test_kv_direct_get
branch
from
136687e
to
09ba556
Compare
|
Freshly rebased on top of latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax KV CAS test which was failing immediately upon reading a key with a revision which is known to be stale.
Instead, retry the read until a newer version is returned.
Signed-off-by: Marco Primi marco@synadia.com