Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dates in licence headers #4670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

piotrpio
Copy link
Contributor

Updated dates on files with outdated licenses.

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from a team as a code owner October 17, 2023 17:27
@piotrpio piotrpio requested a review from wallyqs October 17, 2023 17:27
@ripienaar
Copy link
Contributor

Typically the rule is you update a date in the header only when a particular file changes - not the entire repo at a time. That's how I understood the "rule" anyway?

So we'd totally have files here that should not change.

@piotrpio
Copy link
Contributor Author

@ripienaar all the files changed in this PR had outdated license, I did not touch the ones that were up to date. The only thing I was not sure about were the ones where e.g. header said 2019-2020, and the file was changed in 2021 - I updated those to 2023 as well, but maybe they should have 2019-2021? 🤷

@ripienaar
Copy link
Contributor

That's what I mean - a file last edited in 2021 should have a header saying 2021 not 2023.

At least thats how I understand it - but really I think this is a bad idea so I dont know the exact rule, so take my comment rather as we should ask someone who knows rather than you should not do it :)

@piotrpio
Copy link
Contributor Author

@ripienaar Yeah, not sure about the rules as well. My idea here was to keep the license date consistent with last commit date - so when I'm updating a file now because the last commit year > license year, I'm putting 2023, so that it's in line with this exact commit (for future reference).

Again, I did not touch files that were fine, e.g. server/auth_test.go has Copyright 2012-2022 and was last updated in 2022, so it stays without any changes.

@ripienaar
Copy link
Contributor

Oh, @piotrpio I missed that you didnt update those files, sorry for the noise in that case I think we're good.

@ripienaar
Copy link
Contributor

Be great if someone could write a linter for this stuff that we can just catch them on every PR!

@derekcollison
Copy link
Member

You update the copyright on changes.. If no changes, leave as is.

@piotrpio
Copy link
Contributor Author

@derekcollison I did that - all those files had outdated license.

@piotrpio
Copy link
Contributor Author

@ripienaar Yeah, linter would be nice, I'll give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants