Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] remove extra system headers on direct gets #4618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX] remove extra system headers on direct gets #4618

wants to merge 1 commit into from
+132 −0

Commits on Oct 4, 2023

  1. [FIX] direct get APIs can contain duplicate Nats-* headers, because… 

    … it simply appends JSON bytes to existing headers. If the message was onboarded on a republish, this will contain system headers. Since headers are not ordered and can contain multiple values for the same header, this can break KV clients as well as create ambiguity on the stream that yielded the message.

Fix #4573
    @aricart
    aricart committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    7138157 View commit details
    Browse the repository at this point in the history