Report observer mode in replica state #4582
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
changed the title
neilalexander
added a commit
to nats-io/jsm.go
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
to nats-io/nats.go
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
to nats-io/nats.go
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
to nats-io/nats.go
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
to nats-io/natscli
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
to nats-io/jsm.go
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
added a commit
to nats-io/natscli
that referenced
this pull request
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/observers
branch
from
73dd3e9
to
fe84762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't surface anything through the JS API that reports whether a node is in observer state or not (i.e. because of LDM or because of
js_cluster_migrate). In part this is because nodes don't currently track whether other nodes in the group are observers or not.This branch adds a new proposal type to the Raft layer to signal when a node enters or leaves observer mode. We then use this to bubble up the observer state through the stream and consumer state, which the CLI can use to render the state. This should make it possible to debug whether a clustered asset is leaderless and/or not voting because all of the nodes are observers.
This PR has a one or two things to clean up before merge — namely we need to merge changes to nats.go first to remove the
replacefromgo.mod, the JS API schema and CLI also need changes for this too.Signed-off-by: Neil Twigg neil@nats.io