Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify allow_trace behaviors for services and streams #269

Merged
merged 1 commit into from Feb 29, 2024

Conversation

ripienaar
Copy link
Contributor

No description provided.

@ripienaar ripienaar requested a review from bruth February 28, 2024 12:58
adr/ADR-41.md Outdated Show resolved Hide resolved
adr/ADR-41.md Outdated
imports = [
// on a stream import the directin of flow is from exporter into
// the importer, so the importer need to allow tracing
{stream: {account: user, subject: ticker}, allow_trace: true}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be account A, given the above code block? Should the ticker export be defined as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be A, mauby be clearer.

I am just showing that the thing that needs to be set it only on the importer of a stream import, the export doesnt change.

But on a service the export change not the import.

So only showing the bits that actually different from typical

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there is a chance it confuse the average reader, but we can allow a contribution to address if you don't want to fix it now.

Copy link
Contributor Author

@ripienaar ripienaar Feb 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well fully the idea is that these documents are not for the average reader, we absolultely need to treat these as input for docs to be written that are appropriate for general audience not output.

It's implementers and early adopters and deep technical reference.

Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar ripienaar merged commit f8e7f4f into main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants