Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial guide on message tracing #267

Merged
merged 4 commits into from Feb 24, 2024
Merged

Initial guide on message tracing #267

merged 4 commits into from Feb 24, 2024

Conversation

ripienaar
Copy link
Contributor

No description provided.

Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar
Copy link
Contributor Author

@kozlovic just a rough first run through the tracing stuff to help some people, if you don't mind taking a look through. Esepcially help me make sense of the hop stuff :)

Signed-off-by: R.I.Pienaar <rip@devco.net>
Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar
Copy link
Contributor Author

Note: I need to add about the sharing between accounts and detail for the new property for % sampling

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

adr/ADR-41.md Outdated Show resolved Hide resolved
adr/ADR-41.md Outdated Show resolved Hide resolved
adr/ADR-41.md Outdated Show resolved Hide resolved
adr/ADR-41.md Show resolved Hide resolved
adr/ADR-41.md Outdated Show resolved Hide resolved
adr/ADR-41.md Outdated Show resolved Hide resolved
adr/ADR-41.md Show resolved Hide resolved
adr/ADR-41.md Show resolved Hide resolved
adr/ADR-41.md Show resolved Hide resolved
Signed-off-by: R.I.Pienaar <rip@devco.net>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ripienaar
Copy link
Contributor Author

LGTM!

Thanks, will mege after your server PR

@ripienaar ripienaar merged commit 7c97f13 into main Feb 24, 2024
1 check passed
@ripienaar ripienaar deleted the msg_trace branch February 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants