Types - Added Better Typings for Width, Height + Size #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
width
,height
andsize
able to accept astring
value as well as anumber
value (i.e. for usingrem
,px
, etc.)However, this is similar to the inherent attributes associated with an
<svg>
tag:So - an alternate solution may be just removing these attributes from the props entirely, and just relying on the
extends HTMLAttributes<"svg">
instead.