Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passthrough attributes #202

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

natemoo-re
Copy link
Owner

WIP, but the goal is to allow presentational attributes to be applied directly to the rendered icon. The main use case is stroke-width, but there might be others that I haven't seen yet!

Still TODO

  • make sure sprites are handled properly
  • less hacky replacement behavior (ultrahtml for parsing?)
  • Handle true / false attribute values
  • Handle injecting the value when the attribute does not already exist

Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: cf2f5eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro-icon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 7:57pm
astroicon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 7:57pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant