add JsonNet13, bump dependencies, fix naming #290
Conversation
Remove three projects (JsonNet10, JsonNet11, JsonNet9). Add new project (JsonNet13). The `runtimeOptions` property in the `RuntimeConfig` class was marked as obsolete and replaced with `RuntimeOptions`. The version of `System.Data.SqlClient` in `SqlClientApp.csproj` was updated from 4.8.3 to 4.8.6.
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "JsonNet10", "test\TestProjects\JsonNet10\JsonNet10.csproj", "{FFBDDBE3-3E51-4CE6-BDF6-04AB66FFF658}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "JsonNet11", "test\TestProjects\JsonNet11\JsonNet11.csproj", "{F2937B44-20B4-4E74-B5F5-99AF465424F3}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "JsonNet9", "test\TestProjects\JsonNet9\JsonNet9.csproj", "{D71D858B-35AF-452F-926F-873DDD990B27}" | ||
| EndProject |
There was a problem hiding this comment.
What was the motivation for removing these projects from the solution file?
There was a problem hiding this comment.
Newtonsoft.JSON 9-12 have at least one high vulnerability (https://www.nuget.org/packages/Newtonsoft.Json/12.0.3).
I think those old versions shouldn't be supported, that's why I've added a new project with version 13.0.3
| @@ -133,6 +127,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mixer", "samples\dynamic-im | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ServiceImplementation", "samples\dynamic-implementation\ServiceImplementation\ServiceImplementation.csproj", "{39BCFE6F-50C4-45AE-8D13-38FB423AB619}" | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "JsonNet13", "test\TestProjects\JsonNet13\JsonNet13.csproj", "{9F7041CA-98DE-4DFD-8BFC-71B0338D4CB0}" | |||
There was a problem hiding this comment.
How will this new test project be used? I did not see anything which references it, so I'm not sure if this is needed or not.
There was a problem hiding this comment.
I've added this project as a replacement for 9,10,11 versions.
The tests are empty for those projects (https://github.com/natemcmaster/DotNetCorePlugins/blob/v2/test/TestProjects/JsonNet11/Class1.cs), so this can be added in the future.
The idea was to remove all libraries that have vulnerabilities
There was a problem hiding this comment.
Ok. These old versions were selected intentionally because this loader is trying to assert that it can load different major versions of an assembly. As this is test-only code, I am not concerned about security vulnerabilities.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #290 +/- ##
===========================================
- Coverage 66.80% 53.73% -13.07%
===========================================
Files 14 14
Lines 494 495 +1
Branches 0 126 +126
===========================================
- Hits 330 266 -64
- Misses 164 185 +21
- Partials 0 44 +44 ☔ View full report in Codecov by Sentry. |
I've removed three projects (JsonNet10, JsonNet11, JsonNet9) and added a new project (JsonNet13).
The
runtimeOptionsproperty in theRuntimeConfigclass was marked as obsolete and replaced withRuntimeOptions. The version ofSystem.Data.SqlClientinSqlClientApp.csprojwas updated from 4.8.3 to 4.8.6.This is my first contribution, before starting to use the project in my POC.
I plan to clean the naming and add comments to public classes that currently miss them.
My old app (Autofac based) uses expressions and three lifetime scopes, so hopefully I'll be able to replace Autofac with your library and simplify the logic as much as possible.