Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/horizon test #239

Merged
merged 3 commits into from Aug 17, 2023
Merged

Bug/horizon test #239

merged 3 commits into from Aug 17, 2023

Conversation

kjjarvis
Copy link
Contributor

Small bugfix to original hotfix solution to issue with horizon. Also adding tests for horizon functionality

@kjjarvis kjjarvis requested a review from teubert August 15, 2023 23:06
@github-actions
Copy link

Thank you for opening this PR. Since this is a release branch, the PR must complete the release checklist, below:

  • Check that each new feature has corresponding tests

  • Confirm all dependencies are in the following: requirements.txt, setup.py, the bottom of dev_guide.rst

  • Confirm that all issues associated with the release have been closed (i.e., requirements have been met) or assigned to another release

  • Run unit tests python -m tests

  • If present, run manual tests python -m tests.test_manual

  • Review the template(s)

  • Review static-analysis/linter results

  • Review the tutorial

  • Run and review the examples

  • Check that all examples are tested

  • Check new files in PR for any accidentally added

  • Check documents

    • Check that all desired examples are in docs

    • General review: see if any updates are required

  • Rebuild sphinx documents: sphinx-build sphinx_config/ docs/

  • Write release notes

  • Update version number in src/*/init.py and setup.py

  • For releases adding new features- ensure that NASA release process has been followed.

  • Confirm that on GitHub Releases page, the next release has been started and that a schedule is present including at least Release Date, Release Review Date, and Release Branch Opening Date.`

tests/test_horizon.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@teubert teubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one request

@kjjarvis kjjarvis merged commit f73a512 into release/v1.5.1 Aug 17, 2023
0 of 3 checks passed
@kjjarvis kjjarvis deleted the bug/horizon_test branch August 17, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants