Hotfix v1.5.1 #238
Merged
Hotfix v1.5.1 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make sure, this change is needed precisely because of our Monte Carlo works. In other words, changes in the other predictors do not need to be changed. |
Bug/horizon test - fixes bug in horizon hotfix and adds tests of horizon feature
|
Approved for release. Tests run locally on my machine and all code has been reviewed. |
fixing bug: array and keys did not match in particle_filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with horizon.
When 1. a user sets a horizon, 2. one event occurs before the horizon, and 3. the horizon is hit before the second event - then horizon will not work properly
Root cause is a change in prog_models where horizon is now relative to t0. t0 is used to simulate subsequent events (continuing from where the last one stopped).
Solution is to reduce horizon by t0 when continuing simulation