add uat option to validator script and document in readme #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton @niarenaw for your contribution! Let me test this out against some of our existing test cases and then get to approving / merging 👍 |
riverma
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Thank you for this contribution @niarenaw - excellent!
Couple suggestions inline but two I wanted to add:
- Did you make the regex fix to allow the
S1BRTC granules to work? If so could you contribute that to this PR and rename the PR / purpose accordingly? - UAT CMR has less granules than OPS, and I noticed that many times no granules are returned. I think we should add a
sys.exit(1)right after this line since now this is a common occurrence. Would you consider adding that?
|
|
||
| ### Usage Examples | ||
|
|
||
| * Retrieve a list of MGRS Tile Set IDs for the RTC burst processing a given time range on CMR, and filter the results to show only MGRS Tile Sets that had coverage of greater than or equal to 50%. | ||
|
|
||
| ``` | ||
| $ python dswx_s1_validator.py --start "2023-12-05T01:00:00Z" --end "2023-12-05T03:59:59Z" --db MGRS_tile_collection_v0.2.sqlite --threshold 50 | ||
| Querying CMR for time range 2023-12-05T01:00:00Z to 2023-12-05T03:59:59Z. | ||
| Querying CMR for time range 2023-12-05T01:00:00 to 2023-12-05T03:59:59. |
There was a problem hiding this comment.
I think we should keep the Z as that denotes times are expected to be in UTC.
There was a problem hiding this comment.
I get a ValueError, when including Z: ValueError: Invalid isoformat string: '2023-12-05T01:00:00Z'
|
@riverma thanks for you suggested changes -- I've added them. |
hhlee445
approved these changes
Apr 15, 2024
…d failures - Added default value to timestamp arg - Better logging for failure analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed Changes
Testing