Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Tables] Make sure tables auto scroll correctly on first load #7720

Merged
merged 10 commits into from
May 9, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented May 8, 2024

Closes #7669

Describe your changes:

Added an after load action to scroll to the top after a table is first visited. This handles cases where historical telemetry can come in and affect the initial sticky scroll.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta requested a review from davetsay May 8, 2024 22:54
@jvigliotta jvigliotta changed the title Mct7669 [Telemetry Tables] Make sure tables auto scroll correctly on first load May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.59%. Comparing base (977792f) to head (777a860).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7720      +/-   ##
==========================================
+ Coverage   56.12%   56.59%   +0.46%     
==========================================
  Files         673      673              
  Lines       27181    27182       +1     
  Branches     2635     2635              
==========================================
+ Hits        15256    15383     +127     
+ Misses      11595    11468     -127     
- Partials      330      331       +1     
Flag Coverage Δ
e2e-full 23.56% <ø> (ø)
e2e-stable 60.46% <ø> (+1.36%) ⬆️
unit 49.26% <100.00%> (+0.05%) ⬆️
Files Coverage Δ
...ugins/telemetryTable/components/TableComponent.vue 44.23% <100.00%> (+2.78%) ⬆️

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977792f...777a860. Read the comment docs.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested and works perfectly. One request is to label your test as sort descending and add a test for sort ascending.

@jvigliotta jvigliotta requested a review from davetsay May 9, 2024 01:15
@ozyx ozyx added this to the Target:4.0.0 milestone May 9, 2024
@ozyx ozyx added the type:bug label May 9, 2024
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion on how to avoid using hard waits in the e2e

@jvigliotta jvigliotta requested a review from ozyx May 9, 2024 17:02
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label May 9, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label May 9, 2024
@ozyx ozyx merged commit 810d580 into master May 9, 2024
19 checks passed
@ozyx ozyx deleted the mct7669 branch May 9, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry Tables scroll sort should mirror that of order sort
4 participants