Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the setTimeConductorMode, use the close time popup button rather than the submit button to dismiss time popup #7613

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Mar 18, 2024

Closes #7614

Describe your changes:

The submit button(s) in the realtime and fixed time popups trigger network requests (right now).
Also created an issue to perform a noop if there are no changes when submit button is clicked in the time popup here:
#7616

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Target:4.0.0 milestone Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.15%. Comparing base (b7b9ccb) to head (a28c711).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7613      +/-   ##
==========================================
+ Coverage   56.10%   56.15%   +0.05%     
==========================================
  Files         672      672              
  Lines       27111    27111              
  Branches     2635     2635              
==========================================
+ Hits        15210    15224      +14     
+ Misses      11577    11561      -16     
- Partials      324      326       +2     
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.93% <ø> (+0.05%) ⬆️
unit 49.11% <ø> (+0.08%) ⬆️
Files Coverage Δ
src/plugins/timeConductor/TimePopupFixed.vue 32.91% <ø> (ø)
src/plugins/timeConductor/TimePopupRealtime.vue 29.72% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b9ccb...a28c711. Read the comment docs.

@akhenry akhenry enabled auto-merge (squash) March 18, 2024 23:37
@akhenry akhenry added type:bug bug:platform specific to OS/Browser/Installation method labels Mar 18, 2024
@akhenry akhenry merged commit a01f210 into master Mar 18, 2024
27 of 28 checks passed
@akhenry akhenry deleted the fix-time-conductor-dismiss-for-tests branch March 18, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:platform specific to OS/Browser/Installation method type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Use the dismiss button to close time popup (rather than the submit button)
2 participants