Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import perf improvement #7604

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Import perf improvement #7604

wants to merge 3 commits into from

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Mar 18, 2024

Closes #7612

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@akhenry akhenry added this to the Target:4.0.0 milestone Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 59.95%. Comparing base (4027eae) to head (5f999c0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7604      +/-   ##
==========================================
+ Coverage   56.46%   59.95%   +3.48%     
==========================================
  Files         672      430     -242     
  Lines       27112    13472   -13640     
  Branches     2635        0    -2635     
==========================================
- Hits        15310     8077    -7233     
+ Misses      11477     5395    -6082     
+ Partials      325        0     -325     
Flag Coverage Δ
e2e-full 23.57% <0.00%> (-18.15%) ⬇️
e2e-stable 59.86% <0.00%> (-0.08%) ⬇️
unit ?
Files Coverage Δ
...ugins/importFromJSONAction/ImportFromJSONAction.js 14.54% <0.00%> (-50.72%) ⬇️

... and 376 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4027eae...5f999c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import from JSON is extremely slow with large imports
2 participants