Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7558)[webpack]: handle git errors gracefully and clearly #7562

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Mar 7, 2024

Closes #7558

Describe your changes:

Make it clear that any git errors during build are non-fatal and can be ignored at the expense of version info. This happens when building from zipped source as it does not include the .git/ folder

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Mar 7, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Mar 7, 2024
@ozyx ozyx changed the title fix(#7558): handle git errors gracefully and clearly fix(#7558)[webpack]: handle git errors gracefully and clearly Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.18%. Comparing base (5fc5c13) to head (49906b8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7562      +/-   ##
==========================================
+ Coverage   56.16%   56.18%   +0.01%     
==========================================
  Files         672      672              
  Lines       27112    27112              
  Branches     2635     2635              
==========================================
+ Hits        15227    15232       +5     
+ Misses      11560    11555       -5     
  Partials      325      325              
Flag Coverage Δ
e2e-full 23.60% <ø> (ø)
e2e-stable 59.96% <ø> (ø)
unit 49.14% <ø> (+0.01%) ⬆️

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc5c13...49906b8. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up warnings thrown if .git folder not present on build
2 participants