Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLA Needed] Makefile and Dockerization/Podman of OpenMCT #7557

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

haisamido
Copy link

@haisamido haisamido commented Mar 5, 2024

Closes #7556

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue? Makefile and Dockerization of openMCT #7556
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.86%. Comparing base (8c2558b) to head (0f6897c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7557      +/-   ##
==========================================
- Coverage   55.64%   54.86%   -0.79%     
==========================================
  Files         672      672              
  Lines       26996    26996              
  Branches     2626     2626              
==========================================
- Hits        15023    14812     -211     
- Misses      11254    11463     +209     
- Partials      719      721       +2     
Flag Coverage Δ *Carryforward flag
e2e-full 41.85% <ø> (ø) Carriedforward from 8c2558b
e2e-stable 55.78% <ø> (-3.81%) ⬇️
unit 48.52% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

see 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2558b...0f6897c. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Mar 5, 2024
@ozyx ozyx changed the title Makefile and Dockerization/Podman of OpenMCT [CLA Needed] Makefile and Dockerization/Podman of OpenMCT Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.86%. Comparing base (a5c6b14) to head (0f6897c).

❗ Current head 0f6897c differs from pull request most recent head a607b6c. Consider uploading reports for the commit a607b6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7557      +/-   ##
==========================================
- Coverage   56.60%   54.86%   -1.74%     
==========================================
  Files         672      672              
  Lines       27120    26996     -124     
  Branches     2632     2626       -6     
==========================================
- Hits        15351    14812     -539     
- Misses      11441    11463      +22     
- Partials      328      721     +393     
Flag Coverage Δ *Carryforward flag
e2e-full 41.85% <ø> (+0.08%) ⬆️ Carriedforward from 8c2558b
e2e-stable 55.78% <ø> (-4.57%) ⬇️
unit 48.52% <ø> (-0.59%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 297 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c6b14...a607b6c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants