Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Allow automatic closing of panes when nav object is clicked #7553

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rukmini-bose
Copy link
Contributor

@rukmini-bose rukmini-bose commented Mar 5, 2024

Closes #7313

Describe your changes:

  • Adds vue logic such that when a mobile device is in portrait mode, clicking on navigation objects (from the tree, Recent Objects, or search) will automatically close the pane and navigate the user to the selected object
  • Adds CSS logic such that the Object Tree is a static width. Currently, our code uses the desktop logic, causing the tree to change widths whenever we switch from desktop to mobile.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (b2b0837) to head (340b4a6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7553      +/-   ##
==========================================
+ Coverage   56.14%   56.17%   +0.02%     
==========================================
  Files         672      672              
  Lines       27128    27133       +5     
  Branches     2635     2635              
==========================================
+ Hits        15232    15242      +10     
+ Misses      11569    11564       -5     
  Partials      327      327              
Flag Coverage Δ
e2e-full 23.17% <100.00%> (-0.41%) ⬇️
e2e-stable 59.97% <80.00%> (+0.06%) ⬆️
unit 49.11% <80.00%> (+<0.01%) ⬆️
Files Coverage Δ
src/ui/router/ApplicationRouter.js 88.23% <100.00%> (+0.60%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b0837...340b4a6. Read the comment docs.

@rukmini-bose rukmini-bose marked this pull request as ready for review March 14, 2024 22:18
@rukmini-bose rukmini-bose added type:bug bug:regression It used to work. Now it doesn't :( not_viper Temporary label to define bugs that won't affect viper deployments labels Mar 14, 2024
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks great, good work. This PR is not intended to fix the tree vs. recent objects problem (#7357) which is going to create a problem when testing. So with that, some changes:

  1. The original issue needs testing notes that include a callout about [Mobile Support] Object Tree is being hidden when switching from Portrait to Landscape Mode #7357. You should have the user exercise the system starting with tree collapsed and expanded, in both portrait and landscape, clicking from the tree and search results in all those permutations - except tree/landscape.
  2. The PR checklist and author checklists need to be completed.

@akhenry akhenry self-requested a review March 20, 2024 16:54
@rukmini-bose
Copy link
Contributor Author

Testing Instructions: #7313

@akhenry akhenry removed this from the Target:4.0.0 milestone Mar 20, 2024
Copy link
Contributor

@charlesh88 charlesh88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@ozyx ozyx added this to the Target:4.0.1 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( not_viper Temporary label to define bugs that won't affect viper deployments type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile Support] Clicking navigation objects should automatically close the tree pane
5 participants