Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from JSON is extremely slow with large imports #7612

Closed
2 of 7 tasks
akhenry opened this issue Mar 18, 2024 · 4 comments · Fixed by #7654 · May be fixed by #7604
Closed
2 of 7 tasks

Import from JSON is extremely slow with large imports #7612

akhenry opened this issue Mar 18, 2024 · 4 comments · Fixed by #7654 · May be fixed by #7604
Labels
severity:critical type:bug verified Tested or intentionally closed
Milestone
Target:4.0.1

Comments

@akhenry
Copy link
Contributor

akhenry commented Mar 18, 2024 •
edited

Summary

Importing very large JSON files (on the order of megabytes) is extremely slow. This would be less of an issue if Open MCT gave the user some feedback that it was doing something, but it doesn't.

Expected vs Current Behavior

Import from JSON has some inefficiencies which could be improved to speed up the import process. The user should be informed that an import is in progress.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@akhenry akhenry mentioned this issue Mar 18, 2024
Draft
14 tasks
@akhenry
Copy link
Contributor Author

akhenry commented Mar 22, 2024

Assigning severity of critical. This issue significantly impairs the usage of this functionality, and functionally blocks it for large imports.

@akhenry akhenry added this to the Target:4.0.1 milestone Mar 22, 2024
@akhenry akhenry self-assigned this Mar 22, 2024
@scottbell scottbell mentioned this issue Mar 29, 2024
Merged
14 tasks
@scottbell scottbell linked a pull request Mar 29, 2024 that will close this issue
Improve performance of JSON import and add progress bar #7654
Merged
14 tasks
@scottbell
Copy link
Contributor

To test:

  1. Use the attached Big Test Folder (2).json.zip to initiate an import.
  2. Ensure the import finishes in a timely manner and the progress bar appears
  3. Create your own folder, with nested objects and folders. Export it.
  4. Ensure that import works properly too.

@davetsay
Copy link
Contributor

verified

@akhenry akhenry added the verified Tested or intentionally closed label Apr 16, 2024
@ozyx
Copy link
Member

ozyx commented Apr 16, 2024

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Target:4.0.1
4 participants
@davetsay @akhenry @ozyx @scottbell