Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up warnings thrown if .git folder not present on build #7558

Open
ozyx opened this issue Mar 5, 2024 · 0 comments · May be fixed by #7562
Open

Clean up warnings thrown if .git folder not present on build #7558

ozyx opened this issue Mar 5, 2024 · 0 comments · May be fixed by #7562
Assignees
@ozyx
Labels
severity:trivial type:maintenance tests, chores, or project maintenance

Comments

@ozyx
Copy link
Member

ozyx commented Mar 5, 2024 •
edited

Although the error messages look scary and say "fatal", this is actually just a warning. Open MCT will still build properly and start. The cause is that when downloading source as zip from GitHub, the .git folder, which we use to parse the build's branch and commit hash, is not included.
We should clean this up and make it clearer that it's only a warning and can be ignored (at the cost of build info on the "about" screen).

Originally posted by @ozyx in #7554 (comment)
@ozyx ozyx self-assigned this Mar 5, 2024
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Mar 6, 2024
@ozyx ozyx linked a pull request Mar 7, 2024 that will close this issue
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozyx ozyx

Labels
severity:trivial type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#7558)[webpack]: handle git errors gracefully and clearly nasa/openmct
2 participants
@ozyx @unlikelyzero