Cumulus 1063 fix build #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Externals entries need to be added to webpack for all of the possible database external requirements that *aren't* included in the api package.json. This is due to oddness in the way knex is referencing said libraries, see commentary at : knex/knex#1128
|
@yjpa7145 this should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add knex db externals to test/api package.
Externals entries need to be added to webpack for all of the possible
database external requirements that aren't included in the api
package.json.
This is due to oddness in the way knex is referencing said libraries,
see commentary at : knex/knex#1128