Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecarton/investigations/3456 stricter typing #3596

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Ecarton/investigations/3456 stricter typing #3596

wants to merge 49 commits into from
+567 −101

Conversation

etcart
Copy link
Contributor

@etcart etcart commented Feb 19, 2024

This is meant to demo a possible way of writing 3456

Changes

  • placing type checkers in the same files that declare the types
  • expanding type checking to more firmly check values

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

ecarton added 30 commits February 5, 2024 23:20
add error to message packaging in DLQ
4b54f24
tests added to include error message
413ff20
include error message in s3 output
7f87710
merge master
0a467fb
changelog for curent changes
5c270a3
Merge branch 'master' into CUMULUS-3456-DLA-clarity
0af5da2
body arg needs to be a string
f41179a
capture extra fields and pack them in dlq
3a632cc
remove unused lambda extractor
7a4fa3b
just pass through entire sqs message in write to s3
1a10f74
? syntax to make this much more elegant
d208018
lint cleanup
87aeef8
catch failed sqs parsing just in case
eb62519
merge master
2e0e539
small change to clarify sf lambda ingest error, very not finished
562c29b
info not log
ed4dbdb
misunderstood syntax fixed
5ebb85d
parse failure clarification log
3c3c49b
merge master
09d38de
remove debug elements from sqs to db
f4ded49
capture data on write-to-s3 side
b3d55f7
need to await an async
cdb478e
transition parsing of message contents to s3 side WIP
30ea8ab
cleanup and tests for moving meta capture to s3 side
927a85f
bring error out from body to top level in s3
898867b
adding jsdocs
1667922
fix up of integration test for DLA
6f3a015
linter cleanup
54f6482
merge master
fabe8e4
changelog
41b04db
ecarton added 19 commits February 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@etcart