Convert sa to ptr and memory leakage fix. #184
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I compiled using make, I got the following error:
To fix it, I changed the sa array into a pointer initialized with
calloc
, I freed it in thesadb_close()
function.This solves it because if sa is an array, comparing to NULL always returns false because
array != NULL
. So I converted the sa to pointer.Line 311:
To my understanding there are a few problems with this line,
sa[1].arsn_len = 2
, whilesa[12].arsn_len = 0
I think this line was meant to be
but either way, this line causes a memory leakage that can be solved by not setting it to anything (so that
sa[12].arsn = NULL
).Therefore, considering that
sa[12].arsn_len = 0
, thensa[12].arsn = NULL
. This was correctly applied to sa[8] but not here.All tests passed.