-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-9845: Allow the tools and services to collection associations to use the generic association API. #2118
Conversation
…use the generic assocation API.
Can we update on the EER - good catch - I have updated the documentation to remove services/tools/. the variable association still can't be made through this API - that is a different ticket. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2118 +/- ##
==========================================
- Coverage 57.77% 57.74% -0.03%
==========================================
Files 1044 1044
Lines 70356 70391 +35
Branches 1996 1989 -7
==========================================
Hits 40645 40645
- Misses 27851 27892 +41
+ Partials 1860 1854 -6 ☔ View full report in Codecov by Sentry. |
@@ -25,8 +25,8 @@ | |||
(defn- context->user-id | |||
"Returns user id of the token in the context. Throws an error if no token is provided" | |||
[context] | |||
(if-let [token (:token context)] | |||
(util/lazy-get context :user-id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this space back in, both branches of if should be at same indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Overview
What is the feature/fix?
Allow the tools and services to collection associations to use the generic association API.
What is the Solution?
Allow the tools and services to collection associations to use the generic association API.
What areas of the application does this impact?
Tools and Services Associations
Checklist