CMR 9792: Int test cleanup part 1

[jmaeng72]

Overview

What is the feature/fix?

Linter errors existed in system-int-test project

What is the Solution?

Since I was already looking at integration tests for research, I decided to do some linter fixes. These are only partial of the many linter errors in the repo.

What areas of the application does this impact?

integration tests

Checklist

• I have updated/added unit and integration tests that prove my fix is effective or that my feature works
• New and existing unit and int tests pass locally and remotely with my changes
• I have removed unnecessary/dead code and imports in files I have changed
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 35.89744% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 24.75%. Comparing base (289c472) to head (869ac84).
Report is 6 commits behind head on master.

Files	Patch %	Lines
...test/src/cmr/system_int_test/utils/ingest_util.clj	38.46%	8 Missing ⚠️
...nt-test/src/cmr/system_int_test/utils/tag_util.clj	0.00%	4 Missing ⚠️
...tem-int-test/src/cmr/system_int_test/data2/kml.clj	25.00%	3 Missing ⚠️
...em-int-test/src/cmr/system_int_test/data2/core.clj	33.33%	2 Missing ⚠️
...nt-test/src/cmr/system_int_test/data2/opendata.clj	0.00%	2 Missing ⚠️
...rc/cmr/system_int_test/utils/subscription_util.clj	0.00%	2 Missing ⚠️
...st/src/cmr/system_int_test/utils/variable_util.clj	0.00%	2 Missing ⚠️
...t-test/src/cmr/system_int_test/data2/atom_json.clj	50.00%	1 Missing ⚠️
...st/src/cmr/system_int_test/utils/provider_util.clj	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2113       +/-   ##
===========================================
- Coverage   57.81%   24.75%   -33.06%     
===========================================
  Files        1044     1044               
  Lines       70318    70296       -22     
  Branches     1966     1031      -935     
===========================================
- Hits        40653    17404    -23249     
- Misses      27808    51861    +24053     
+ Partials     1857     1031      -826     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jceaser]

I left several comments

[jaybarra]

Cases where there are a slew of initializations done in a let block but where we don't actually care about the returned object could be moved to outside the let.

[jmaeng72]

There is a note above that says NOTE - most of the following bindings could be ignored with _, but they are assigned to vars to make it easier to see what is being ingested. So I think we can keep it in there for easier reading

[jaybarra]

Suggested change

	In the CI environment, system integration tests are broken into three groups.
	In the CI environment, system integration tests are broken into multiple groups.

Future proof in the case more or fewer groups are used.