Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9794: Fixing linting issues. #2108

Merged
merged 7 commits into from May 2, 2024
Merged

CMR-9794: Fixing linting issues. #2108

merged 7 commits into from May 2, 2024

Conversation

eereiter
Copy link
Contributor

Overview

What is the feature/fix?

Fixing linting issues for umm-lib

What is the Solution?

Fixing linting issues for umm-lib

What areas of the application does this impact?

umm-lib

Checklist

  • [ x] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit and int tests pass locally and remotely with my changes
  • [ x] I have removed unnecessary/dead code and imports in files I have changed
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 95.66004% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 57.82%. Comparing base (832e41a) to head (df030c8).
Report is 10 commits behind head on master.

Files Patch % Lines
umm-lib/src/cmr/umm/iso_smap/granule/orbit.clj 76.31% 9 Missing ⚠️
umm-lib/src/cmr/umm/umm_spatial.clj 33.33% 6 Missing ⚠️
...test/src/cmr/system_int_test/utils/search_util.clj 91.37% 5 Missing ⚠️
umm-lib/src/cmr/umm/echo10/granule.clj 95.19% 3 Missing and 2 partials ⚠️
umm-lib/src/cmr/umm/iso_mends/granule.clj 44.44% 5 Missing ⚠️
umm-lib/src/cmr/umm/start_end_date.clj 78.94% 2 Missing and 2 partials ⚠️
umm-lib/src/cmr/umm/umm_core.clj 25.00% 3 Missing ⚠️
...lib/src/cmr/umm/iso_mends/collection/personnel.clj 60.00% 2 Missing ⚠️
...-lib/src/cmr/umm/iso_smap/collection/personnel.clj 60.00% 2 Missing ⚠️
umm-lib/src/cmr/umm/dif10/collection/platform.clj 88.88% 0 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2108      +/-   ##
==========================================
+ Coverage   56.53%   57.82%   +1.29%     
==========================================
  Files        1041     1041              
  Lines       70289    70252      -37     
  Branches     1914     1973      +59     
==========================================
+ Hits        39735    40623     +888     
+ Misses      28690    27766     -924     
+ Partials     1864     1863       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eereiter eereiter merged commit 597ef82 into master May 2, 2024
3 checks passed
@eereiter eereiter deleted the CMR-9794 branch May 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants