Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9839: Granule metadata with granuleSize info yields unexpected results at ingest #2103

Merged
merged 3 commits into from Apr 30, 2024

Conversation

sxu123
Copy link
Member

@sxu123 sxu123 commented Apr 25, 2024

Overview

What is the feature/fix?

CMR granule json search. Customer wants granule_size returned to be calculated differently.

What is the Solution?

Add all the SizeInBytes (or Size if SizeInBytes is absent) in all the files when ingesting UMM-G granule and use it for granule_size.

What areas of the application does this impact?

CMR granule search

Checklist

  • [ x] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit and int tests pass locally and remotely with my changes
  • [ x] I have removed unnecessary/dead code and imports in files I have changed
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 57.84%. Comparing base (d0423b1) to head (6fa4bbf).
Report is 3 commits behind head on master.

Files Patch % Lines
...-lib/src/cmr/umm_spec/test/umm_g/expected_util.clj 68.75% 5 Missing ⚠️
...m-spec-lib/src/cmr/umm_spec/umm_g/data_granule.clj 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   57.83%   57.84%           
=======================================
  Files        1041     1041           
  Lines       70289    70321   +32     
  Branches     1984     1982    -2     
=======================================
+ Hits        40653    40677   +24     
- Misses      27770    27775    +5     
- Partials     1866     1869    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 changed the title Cmr 9839 Granule metadata with granuleSize info yields unexpected results at ingest CMR:9839 Granule metadata with granuleSize info yields unexpected results at ingest Apr 29, 2024
@eudoroolivares2016 eudoroolivares2016 changed the title CMR:9839 Granule metadata with granuleSize info yields unexpected results at ingest CMR-9839: Granule metadata with granuleSize info yields unexpected results at ingest Apr 29, 2024
@sxu123 sxu123 merged commit b4fbfec into master Apr 30, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants