Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9776: Resolve linter errors & warnings in common-app-lib; add linting config #2101

Closed
wants to merge 1 commit into from

Conversation

zimzoom
Copy link
Contributor

@zimzoom zimzoom commented Apr 24, 2024

Overview

What is the feature/fix?

Fix clj-kondo errors and warnings on common-app-lib.

Also added .clj-kondo to codebase, including config file and imported config from clj-rewrite.

What is the Solution?

See above, followed clj-kondo docs. See comments in config.edn file.

What areas of the application does this impact?

Quality control

Checklist

  • [x ] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit and int tests pass locally and remotely with my changes
  • [x ] I have removed unnecessary/dead code and imports in files I have changed
  • [x ] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings

@zimzoom
Copy link
Contributor Author

zimzoom commented May 1, 2024

This is a duplicate PR, closing. My apologies

@zimzoom zimzoom closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants