Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9797 elastic-lib migration #2095

Closed
wants to merge 28 commits into from
Closed

Conversation

jceaser
Copy link
Contributor

@jceaser jceaser commented Apr 18, 2024

Overview

CMR-9797: move code into elastic lib

Picked a selection of code and moved it into the elastic lib

What areas of the application does this impact?

Search, Common-Lib, Common-App-Lib, AccessControl, ElasticUtils

List impacted areas.

Checklist

  • I have updated/added unit and integration tests that prove my fix is effective or that my feature works
  • New and existing unit and int tests pass locally and remotely with my changes
  • I have removed unnecessary/dead code and imports in files I have changed
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@zimzoom
Copy link
Contributor

zimzoom commented Apr 18, 2024

FYI, Currently failing to start REPL

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 47.90419% with 261 lines in your changes are missing coverage. Please review.

Project coverage is 58.13%. Comparing base (7443352) to head (7b654a9).
Report is 15 commits behind head on master.

Files Patch % Lines
...c/cmr/elastic_utils/search/es_query_to_elastic.clj 28.72% 129 Missing ⚠️
...rch/results_handlers/reference_results_handler.clj 3.84% 25 Missing ⚠️
...tils-lib/src/cmr/elastic_utils/search/es_index.clj 11.76% 15 Missing ⚠️
...tils-lib/src/cmr/elastic_utils/search/es_debug.clj 20.00% 12 Missing ⚠️
.../results_handlers/atom_spatial_results_handler.clj 20.00% 12 Missing ⚠️
...mr/search/results_handlers/kml_results_handler.clj 0.00% 11 Missing ⚠️
...arch/results_handlers/timeline_results_handler.clj 61.90% 8 Missing ⚠️
...arch/results_handlers/metadata_results_handler.clj 0.00% 6 Missing ⚠️
elastic-utils-lib/src/cmr/elastic_utils/config.clj 78.26% 0 Missing and 5 partials ⚠️
...tils-lib/src/cmr/elastic_utils/datetime_helper.clj 64.28% 5 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2095      +/-   ##
==========================================
- Coverage   58.14%   58.13%   -0.01%     
==========================================
  Files        1042     1045       +3     
  Lines       69804    69856      +52     
  Branches     1962     1955       -7     
==========================================
+ Hits        40587    40613      +26     
- Misses      27372    27402      +30     
+ Partials     1845     1841       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jceaser jceaser closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants