Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled component style updates #40

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Disabled component style updates #40

wants to merge 6 commits into from

Conversation

AaronPlave
Copy link
Member

@AaronPlave AaronPlave commented Jul 17, 2023 •
edited

Styles and implements (where necessary) disabled state for Checkbox, Dropdown, Multiselect, and Switch.

@AaronPlave AaronPlave marked this pull request as ready for review July 17, 2023 23:48
@AaronPlave AaronPlave requested a review from duranb July 17, 2023 23:49
@AaronPlave AaronPlave self-assigned this Jul 17, 2023
duranb
duranb approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! One small question I have is, should the labels also look more greyed out if they're disabled?

@AaronPlave
Copy link
Member Author

Works perfectly! One small question I have is, should the labels also look more greyed out if they're disabled?

Good question, I'll bring it up with the design team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duranb duranb duranb approved these changes

Assignees

@AaronPlave AaronPlave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronPlave @duranb