Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebServer - correct MIME-Type for images #1214 #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DaveSchmid
Copy link

Description

  • correct MIME-Type for images
  • more MIME-Types for known types.
  • secure file name handling.
  • Method function according to parameter naming (filename)

Motivation and Context

  • Fixes #1214

How Has This Been Tested?

Tested with modified WebServer.Sample:
https://github.com/DaveSchmid/Samples/releases/tag/WebServer.Sample-Errors
Sample shows misbehave of wrong MIME-Type.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Signed-off-by: DaveSchmid code@wirzi.com

- more MIME Content Types for known types.
- secure file name handling.
- Method function according to parameter naming (filename)

Signed-off-by: DaveSchmid <code@wirzi.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes mentioned this pull request Jan 23, 2023
14 tasks
@Ellerbach
Copy link
Member

@DaveSchmid, if you still want to add some elements, can you please pull the changes and add the few content type you really want. Again, as they can be passed in the function, it's not really needed to add a lot of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants