Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration and environment variable improvements #4613

Merged
merged 13 commits into from May 13, 2024

Conversation

pwojcikdev
Copy link
Contributor

@pwojcikdev pwojcikdev commented May 11, 2024

This cleans up code related to overriding node configuration:

  • Extracts environment variable reading, which is now done in a more generic, C++ way.
  • Always prints info when an environment variable overrides config.
  • Ensures that configured thread counts are in reasonable ranges. (And slightly tweaks default for request_aggregator)
  • Converts is_<sanitizer> calls to constevals
  • Adds ability to configure number of IO threads by environment variable

@pwojcikdev pwojcikdev requested a review from clemahieu May 12, 2024 13:13
@pwojcikdev
Copy link
Contributor Author

This also fixes a problem where default message processing threads would be 0, that's causing current develop to fail on macos runners.

nano/lib/utility.hpp Outdated Show resolved Hide resolved
nano/lib/env.cpp Show resolved Hide resolved
clemahieu
clemahieu previously approved these changes May 13, 2024
@pwojcikdev pwojcikdev merged commit 147a375 into nanocurrency:develop May 13, 2024
25 of 26 checks passed
@qwahzi qwahzi added this to the V27 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants