Upgrade monkey patch of rack::builder #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote for removing that monkey-patch. |
|
@nakajima @timocratic @jeremyevans Any chance we can get this pulled in and/or compatibility with the latest rack? Related padrino issue here: padrino/padrino-framework#679 |
|
Is rack-flash being maintained anymore? It's not compatible with the just-released Rack 1.4.0. Is there an alternate gem we should switch to? |
|
@chanks I know this is not the ideal answer but for Sinatra and/or Padrino, we now recommend sinatra-flash |
|
@nesquena Thanks! I actually am using Sinatra, and sinatra-flash works great. |
|
Another "me too" on using sinatra-flash as a drop-in replacement, works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for running on rack 1.4.0. It's possible you'll want to retain backwards-compatibility, in which case it'd probably be easiest to check if @ins is nil and make a decision about what to do from there.