Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Fix for 2 vulnerabilities #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #18

wants to merge 1 commit into from

Conversation

naiba4
Copy link
Owner

@naiba4 naiba4 commented Mar 25, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning 
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 169/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: Proof of Concept, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00091, Social Trends: No, Days since published: 278, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.81, Score Version: V5		 Regular Expression Denial of Service (ReDoS)
SNYK-JS-SEMVER-3247795		 No Proof of Concept
high severity 170/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: Proof of Concept, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 0, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 98, Impact: 5.99, Likelihood: 2.83, Score Version: V5		 Prototype Pollution
SNYK-JS-WEB3UTILS-6229337		 Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Mar 25, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@pull-request-quantifier-deprecated Pull Request Quantifier (deprecated)
Copy link

This PR has 6 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +3 -3
Percentile : 2.4%

Total files changed: 1

Change summary by file extension:
.json : +3 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomiclabs/hardhat-etherscan@3.1.8 environment +1 578 kB fvictorio
npm/ethereum-waffle@4.0.10 Transitive: environment, eval, filesystem, network, shell, unsafe +199 50.3 MB ethworks
npm/solidity-coverage@0.8.11 filesystem 0 711 kB cgewecke
npm/undici@5.28.3 environment, network, unsafe 0 1.17 MB matteo.collina

🚮 Removed packages: npm/@nodelib/fs.stat@2.0.5, npm/@nodelib/fs.walk@1.2.8, npm/@nomiclabs/hardhat-etherscan@3.1.0, npm/@types/bn.js@5.1.0, npm/acorn-jsx@5.3.2, npm/ansi-styles@4.3.0, npm/bignumber.js@9.0.2, npm/esquery@1.5.0, npm/esrecurse@4.3.0, npm/estraverse@5.3.0, npm/ethereumjs-util@7.1.5, npm/find-up@5.0.0, npm/ignore@5.3.1, npm/import-fresh@3.3.0, npm/is-glob@4.0.3, npm/js-yaml@4.1.0, npm/minimatch@3.1.2, npm/ms@2.1.2, npm/solidity-coverage@0.7.21, npm/strip-ansi@6.0.1, npm/strip-json-comments@3.1.1, npm/type-detect@4.0.8

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Filesystem access npm/rimraf@2.6.3
Unmaintained npm/safer-buffer@2.1.2
  • Last Publish: 4/8/2018, 10:42:42 AM
  • orphan: npm/safer-buffer@2.1.2
Filesystem access npm/pump@3.0.0
  • orphan: npm/pump@3.0.0
Unmaintained npm/pump@3.0.0
  • Last Publish: 1/31/2018, 9:46:35 AM
  • orphan: npm/pump@3.0.0
Environment variable access npm/request@2.88.2
  • orphan: npm/request@2.88.2
Mild CVE npm/request@2.88.2
  • orphan: npm/request@2.88.2
Network access npm/request@2.88.2
  • orphan: npm/request@2.88.2
Deprecated npm/request@2.88.2
  • orphan: npm/request@2.88.2
Network access npm/request@2.88.2
  • orphan: npm/request@2.88.2
Filesystem access npm/request@2.88.2
  • orphan: npm/request@2.88.2
Network access npm/request@2.88.2
  • orphan: npm/request@2.88.2
Unmaintained npm/regex-not@1.0.2
  • Last Publish: 2/20/2018, 2:31:14 AM
Filesystem access npm/snapdragon@0.8.2
Unmaintained npm/repeat-string@1.6.1
  • Last Publish: 10/23/2016, 4:54:00 PM
Filesystem access npm/y18n@5.0.8
  • orphan: npm/y18n@5.0.8
New author npm/set-value@2.0.1
Unmaintained npm/resolve-url@0.2.1
  • Last Publish: 2/25/2014, 6:48:50 PM
  • orphan: npm/resolve-url@0.2.1
Deprecated npm/resolve-url@0.2.1
  • Reason: https://github.com/lydell/resolve-url#deprecated
  • orphan: npm/resolve-url@0.2.1
Unmaintained npm/randombytes@2.1.0
  • Last Publish: 2/19/2019, 1:48:39 PM
Unmaintained npm/randomfill@1.0.4
  • Last Publish: 2/16/2018, 1:03:56 PM
  • orphan: npm/randomfill@1.0.4
New author npm/ripemd160@2.0.2
Unmaintained npm/ripemd160@2.0.2
  • Last Publish: 4/19/2018, 6:06:43 AM
Unmaintained npm/sha.js@2.4.11
  • Last Publish: 3/20/2018, 12:35:26 AM
Uses eval npm/regenerator-runtime@0.11.1
  • orphan: npm/regenerator-runtime@0.11.1
Environment variable access npm/yargs-parser@20.2.4
  • orphan: npm/yargs-parser@20.2.4
Dynamic require npm/yargs-parser@20.2.4
  • orphan: npm/yargs-parser@20.2.4
Environment variable access npm/yargs-parser@20.2.4
  • orphan: npm/yargs-parser@20.2.4
Filesystem access npm/yargs-parser@20.2.4
  • orphan: npm/yargs-parser@20.2.4
Network access npm/raw-body@2.4.0
  • orphan: npm/raw-body@2.4.0
Environment variable access npm/ansi-colors@4.1.1
  • orphan: npm/ansi-colors@4.1.1
Environment variable access npm/ansi-colors@4.1.1
  • orphan: npm/ansi-colors@4.1.1
Native code npm/secp256k1@4.0.2
Unmaintained npm/servify@0.1.12
  • Last Publish: 8/3/2017, 7:22:11 AM
  • orphan: npm/servify@0.1.12
CVE npm/qs@6.5.2
  • orphan: npm/qs@6.5.2
Filesystem access npm/commander@3.0.2
Shell access npm/commander@3.0.2
Network access npm/send@0.17.1
  • orphan: npm/send@0.17.1
Filesystem access npm/send@0.17.1
  • orphan: npm/send@0.17.1
Network access npm/simple-get@2.8.1
  • orphan: npm/simple-get@2.8.1
Network access npm/simple-get@2.8.1
  • orphan: npm/simple-get@2.8.1
CVE npm/simple-get@2.8.1
  • orphan: npm/simple-get@2.8.1
Trivial Package npm/set-immediate-shim@1.0.1
  • orphan: npm/set-immediate-shim@1.0.1
Uses eval npm/rustbn.js@0.2.0
New author npm/rustbn.js@0.2.0
Minified code npm/rustbn.js@0.2.0
Filesystem access npm/rustbn.js@0.2.0
Unmaintained npm/safe-event-emitter@1.0.1
  • Last Publish: 10/4/2018, 4:07:39 AM
  • orphan: npm/safe-event-emitter@1.0.1
Deprecated npm/safe-event-emitter@1.0.1
  • Reason: Renamed to @metamask/safe-event-emitter
  • orphan: npm/safe-event-emitter@1.0.1
New author npm/semaphore@1.1.0
Unmaintained npm/semaphore@1.1.0
  • Last Publish: 8/8/2017, 4:22:24 PM
Unmaintained npm/pull-cat@1.1.11
  • Last Publish: 8/9/2016, 10:22:34 AM
Unmaintained npm/pull-defer@0.2.3
  • Last Publish: 8/13/2018, 6:02:02 AM
Unmaintained npm/pull-level@2.0.4
  • Last Publish: 2/11/2018, 6:18:44 PM
Unmaintained npm/pull-live@1.0.1
  • Last Publish: 5/20/2016, 8:50:04 PM
Unmaintained npm/pull-pushable@2.2.0
  • Last Publish: 2/17/2018, 8:50:49 PM
Unmaintained npm/pull-window@2.1.4
  • Last Publish: 5/22/2016, 9:13:23 PM
Unmaintained npm/resumer@0.0.0
  • Last Publish: 5/17/2013, 10:20:55 PM
  • orphan: npm/resumer@0.0.0
New author npm/scryptsy@1.2.1
Uses eval npm/seedrandom@3.0.1
Environment variable access npm/@nomiclabs/hardhat-etherscan@3.1.8
Environment variable access npm/@nomiclabs/hardhat-etherscan@3.1.8
Network access npm/undici@5.28.3
Network access npm/undici@5.28.3
Environment variable access npm/undici@5.28.3
Dynamic require npm/solidity-coverage@0.8.11

View full report↗︎

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What are unmaintained packages?

Package has not been updated in more than 5 years and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extra Small
Projects
None yet
Milestone
No milestone
2 participants
@naiba4 @snyk-bot