[BB] Updating the file to accept thresholds #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change accepts thresholds {[Warning] and [Critical] or none } and returns the exit status by comparing the count of "vhost, exchange, binding, queue, channel" with the thresholds which are passed as an input. Executed this change on command line and I could get valid results. Performed sanity checks with all possible approaches and could get expected output.
barryib
reviewed
Mar 27, 2017
| spec => 'warning|w=s', | ||
| help => | ||
| qq{-w, --warning=THRESHOLD[,THRESHOLD[,THRESHOLD[,THRESHOLD[,THRESHOLD]]]] | ||
| Warning thresholds specified in order that the metrics are returned. |
barryib
reviewed
Mar 27, 2017
| spec => 'critical|c=s', | ||
| help => | ||
| qq{-c, --critical=THRESHOLD[,THRESHOLD[,THRESHOLD[,THRESHOLD[,THRESHOLD]]]] | ||
| Critical thresholds specified in order that the metrics are returned. |
There was a problem hiding this comment.
Same as for the warning threshold.
|
@bbhalki1 Thanks for your PR. Just caching up. Can you please update the following doc (pod) for this script according to your changes? |
|
@bbhalki1 ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change accepts thresholds {[Warning] and [Critical] or none } and returns the exit status by comparing the count of "vhost, exchange, binding, queue, channel" with the thresholds which are passed as an input. Executed this change on command line and I could get valid results. Performed sanity checks with all possible approaches and could get expected output.
./check_rabbitmq_objects -H HOSTNAME -u USERNAME -p PASSWORD -w 50,50,50,50,50 -c 100,100,100,100,100 RABBITMQ_OBJECTS OK - Gathered Object Counts | vhost=3;50;100 exchange=39;50;100 binding=37;50;100 queue=27;50;100 channel=4;50;100./check_rabbitmq_objects -H HOSTNAME -u USERNAME -p PASSWORD -c 10,50,100,100,50 RABBITMQ_OBJECTS OK - Gathered Object Counts | vhost=3;;10 exchange=39;;50 binding=37;;100 queue=27;;100 channel=4;;50./check_rabbitmq_objects -H HOSTNAME -u USERNAME -p PASSWORD -w 10,10,10,10,10 -c 100,100,100,100,100 RABBITMQ_OBJECTS WARNING - Gathered Object Counts | vhost=3;10;100 exchange=39;10;100 binding=37;10;100 queue=27;10;100 channel=4;10;100./check_rabbitmq_objects -H HOSTNAME -u nagmonmq -p PASSWORD -w 0,0,0,0,0 -c 100,100,100,100,1 RABBITMQ_OBJECTS CRITICAL - Gathered Object Counts | vhost=3;0;100 exchange=39;0;100 binding=37;0;100 queue=27;0;100 channel=4;0;1