Abstracted store #58
Open
Abstracted store #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only includes a json file store backend and a generic interface future stores can implement to create additional store backends
|
Not sure what happend to the build here, I'm not able to replicate this locally so a little unsure what's happening. |
|
Could you remove the vendor changes from this PR please? It's a bit impossible to review otherwise. Maybe we should remove the vendor dir altogether, relying on go.mod etc. Thinking about this -- I'm not against the idea. dsnet is supposed to be a simple command and this margins on scope creep; however, as config is treated separately already I think it's not a huge change to the architecture. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started an inital idea for abstracted store.
I'm going to implement a sqlite interface as well to check that this works when we add more backends, but I don't think there be hidden dragons in this design.
wdyt @naggie